Remove sqlite provider from preinstalled and use aiosqlite as core dep#48966
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 9, 2025
Merged
Conversation
potiuk
force-pushed
the
move-aiosqlite-to-be-core-dependency
branch
from
6d1245c to
fea7a8c
Compare
ashb
approved these changes
Apr 8, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Sounds good to me -- aiosqlite is a tiny pure-python dep too
kaxil
approved these changes
Apr 8, 2025
potiuk
force-pushed
the
move-aiosqlite-to-be-core-dependency
branch
from
fea7a8c to
159b7d6
Compare
Member
Author
|
OK. I had to also importorskip the |
Member
Author
|
That's probably not the best way of handling it - idealy we should move those failing tests to provider, but I think it's good for now. |
potiuk
force-pushed
the
move-aiosqlite-to-be-core-dependency
branch
4 times, most recently
from
31135e6 to
1a48ba9
Compare
Aiosqlite has never been used by the sqlite provider it is really needed as async extension in case Airflow would be configured with async engine. So if we are removing sqlite provider as preinstalled, we should move aiosqlite as required depdendency of core as otherwise creating async sqlite engine will fail.
potiuk
force-pushed
the
move-aiosqlite-to-be-core-dependency
branch
from
1a48ba9 to
37c8b50
Compare
Member
Author
|
Merging it. There is a new problem exposed by failing docker build test but this one is related to old setuptools version and new wheel - I will solve it separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiosqlite has never been used by the sqlite provider it is really needed as async extension in case Airflow would be configured with async engine. So if we are removing sqlite provider as preinstalled, we should move aiosqlite as required depdendency of core as otherwise creating async sqlite engine will fail.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.